fix: support HTTP URLs in getTitle() for title fetching#21
Open
malladinagarjuna2 wants to merge 1 commit intoneutralinojs:masterfrom
Open
fix: support HTTP URLs in getTitle() for title fetching#21malladinagarjuna2 wants to merge 1 commit intoneutralinojs:masterfrom
malladinagarjuna2 wants to merge 1 commit intoneutralinojs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20
Problem
getTitle()only usedhttps.get(), soneu appify http://localhost:3333(and any HTTP URL) failed with:Users had to pass
--titlefor HTTP URLs.Solution
URLconstructor and choose the request module by protocol.httpforhttp:andhttpsforhttps:when fetching the page to extract the<title>.file:).reject(err)instead ofreject('')ingetTitle()so callers get a proper error.Changes
httpandurlmodules; ingetTitle(), selecthttporhttpsfromnew URL(url).protocoland callprotocol.get(url, ...). ExportedgetTitlefor tests.test:getTitlescript.Testing
npm run test:getTitle(HTTP + invalid protocol; HTTPS optional if network available).npx serve sample-website -p 3333thenneu appify http://localhost:3333— app is created with the page title.